Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on openwebrx, I made the dsp output sample rate adapt to what is requested from the client (it was fixed to 11025 before). When clients with a 48kHz soundcard connect, this results in an output sample rate of 12000, which is not supported by the
deemphasis_nfm_ffsubcommand.I went into the source and tried to build a new filter with the given octave code, which did not work on my end. I have tried to fix it to the best of my knowledge, and used it to build the new filter.
I also rebuilt the existing filters, the results were a little confusing: The 11025 came out exactly the same, while the rest didn't.
The result however seems to work fine, at least as far as I can tell.